refactor: only unmarshal a single page from the tx index#3008
Open
evan-forbes wants to merge 2 commits into
Open
refactor: only unmarshal a single page from the tx index#3008evan-forbes wants to merge 2 commits into
evan-forbes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #2962 (which targets
v0.39.x-celestia) ontomain.The current
tx_searchpath applies pagination too late:rpc/core/tx.go—env.TxIndexer.Search(ctx.Context(), q)returns the fully materialized[]*abci.TxResult.state/txindex/kv/kv.go— accumulatesfilteredHashesas an unboundedmap[string][]byte.state/txindex/kv/kv.go— callstxi.Get(h)for every matching hash, which proto-unmarshals the fullTxResult.rpc/core/tx.go— sorts the entire slice.rpc/core/tx.go— appliesper_pageonly after the full unmarshal+sort.Pyroscope shows this exact path dominating
memory:inuse_space:TxSearch,TxIndex.Get,TxResult.Unmarshal,ExecTxResult.Unmarshal,Event.Unmarshal,EventAttribute.Unmarshal.Per-row cost: a
TxResultis typically 1-10 KB unmarshalled. A lightweight ref(hash, height, index, eventSeq)is ~40-50 B. For a 1M-match query: ~1-10 GB → ~40-50 MB intermediate.Tracked in https://linear.app/celestia/issue/PROTOCO-1572/oom-from-celestia-core-w-many-txsearch-queries.