feat(discovery): add jitter and fix backoff #2967
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nodersteam
commented
Nov 27, 2023
nodersteam
commented
- Replacing time.NewTicker with time.NewTimer
- Adding backoff logic
- Adding jitter to backoff
- Removed unused test variable
…er, adding a backoffDuration, adding a little jitter
nodersteam
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
Is it acceptable to use math/rand or add generation logic via crypto/rand to fix Lint? |
|
@Wondertan Could you please check this PR? |
|
Hey @nodersteam, I am deferring the review of this to @walldiss, as the most prominent expert on that code. |
Got it! Thx |
cristaloleg
changed the title
cristaloleg
reviewed
May 27, 2024
| "time" | ||
|
|
||
| "golang.org/x/sync/errgroup" |
There was a problem hiding this comment.
Better to keep as it was.
| discoveryRetryTimeout = time.Millisecond * 100 // defined in discovery.go | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*20) | ||
| ctx, cancel := context.WithTimeout(context.Background(), time.Minute*10) |
There was a problem hiding this comment.
Why so big? 30x more than before 👀
| continue | ||
| } | ||
| d.backoffDuration = backoffInitialDuration |
There was a problem hiding this comment.
Should we also reset backoffTimer here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.