misc(cel-shed): add a data hash exists | get helper to cel-shed #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramin
requested review from
Wondertan,
cristaloleg,
distractedm1nd,
renaynay,
vgonkivs and
walldiss
as code owners
cristaloleg
reviewed
Jun 12, 2024
cristaloleg
previously approved these changes
Aug 9, 2024
walldiss
reviewed
Aug 9, 2024
Comment on lines
40
to
42
| defer func() { | ||
| err = errors.Join(err, nodestore.Close()) | ||
| }() |
Member
There was a problem hiding this comment.
error reassignment is ineffectual
Comment on lines
+53
to
+57
| err = store.Start(context.Background()) | ||
| if err != nil { | ||
| fmt.Println("Error starting store:", err) | ||
| return err | ||
| } |
cristaloleg
approved these changes
Aug 12, 2024
Member
|
Closed in favour of #4736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created at request of @renaynay a few days ago for helping with some testing, opening for consideration to be saved/committed to
cel-shedfor preservation (assuming it will be useful again)