Skip to content

Fix Typo #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/adr/adr-003-march2022-testnet.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ checkpoint on any new headers.
### `HeaderService` becomes main component around which most other services are focused

Initially, we started with BlockService being the more “important” component during devnet architecture, but overlooked
some problems with regards to sync (we initially made the decision that a celestia full node would have to be started
some problems with regard to sync (we initially made the decision that a celestia full node would have to be started
together at the same time as a core node).

This led us to an issue where eventually we needed to connect to an already-running core node and sync from it. We were
Expand Down Expand Up @@ -183,7 +183,7 @@ for
the data itself. It is possible to get the namespace for each share encoded in inner non-leaf nodes of the NMT tree.
* Pruning for shares.

### [Move IPLD from celetia-node repo into its own repo](https://github.com/celestiaorg/celestia-node/issues/111)
### [Move IPLD from celestia-node repo into its own repo](https://github.com/celestiaorg/celestia-node/issues/111)

Since the IPLD package is pretty much entirely separate from the celestia-node implementation, it makes sense that it
is removed from the celestia-node repository and maintained separately. The extraction of IPLD should also include a
Expand All @@ -192,7 +192,7 @@ documentation also needs updating.

### Implement additional light node verification logic similar to the Tendermint Light Client Model

At the moment, the syncing logic for a **light** nodes is simple in that it syncs each header from a single peer.
At the moment, the syncing logic for a **light** node is simple in that it syncs each header from a single peer.
Instead, the **light** node should double-check headers with another randomly chosen
["witness"](https://github.com/tendermint/tendermint/blob/02d456b8b8274088e8d3c6e1714263a47ffe13ac/light/client.go#L154-L161)
peer than the primary peer from which it received the header, as described in the
Expand Down
6 changes: 3 additions & 3 deletions docs/adr/adr-009-public-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
## Context

Celestia Node has been built for almost half a year with a bottom-up approach to
development. The core lower level components are built first and public API
development. The core lower-level components are built first and public API
around them is getting organically shaped. Now that the project is maturing and
its architecture is better defined, it's a good time to formally define a set of
modules provided by the node and their respective APIs.
Expand All @@ -32,15 +32,15 @@ matching resource constraints of a type.
### Goals

- Ergonomic. Simple, idiomatic and self-explanatory.
- Module centric(modular). The API is not monolithic and is segregated into
- Module-centric(modular). The API is not monolithic and is segregated into
different categorized and independent modules.
- Unified. All the node types implement the same set of APIs. The difference is
defined by different implementations of some modules to meet resource
requirements of a type. Example: FullAvailability and LightAvailability.
- Embeddable. Simply constructable Node with library style API. Not an
SDK/Framework which dictates users the way to build an app, but users are those
who decide how they want to build the app using the API.
- Language agnostic. It should be simple to implement similar module
- Language-agnostic. It should be simple to implement similar module
interfaces/traits in other languages over RPC clients.

### Implementation
Expand Down