fix(share/shwap/getters): set span err only if all getters truly failed, otherwise just record err in span for single getter failure #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4130 +/- ##
==========================================
- Coverage 44.83% 44.82% -0.02%
==========================================
Files 265 309 +44
Lines 14620 22704 +8084
==========================================
+ Hits 6555 10177 +3622
- Misses 7313 11441 +4128
- Partials 752 1086 +334 ☔ View full report in Codecov by Sentry. |
renaynay
force-pushed
the
get-err-record-prop
branch
from
25ededc to
34f5c6b
Compare
…ed, otherwise record err in span for single getter failure, not top level refactor(share/shwap/getters): Try to make err reporting more explicit in cascadeGetters
renaynay
force-pushed
the
get-err-record-prop
branch
from
34f5c6b to
7411f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span records
all getters failedif only 1 getter failed but get op succeeds on 2nd.