feat(cel-shed): add RTT measurement feature for bootstrappers #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to enhance diagnostics and monitoring capabilities refactor(p2p.go): restructure connection handling and logging to support JSON output and improved RTT statistics processing
aWN4Y25pa2EK
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
…ariable types instead of %s for consistency and better readability
…e string versions of duration fields for better readability in output refactor(p2p.go): change RTTStats struct to exclude original duration fields from JSON output while adding new string fields for JSON serialization
renaynay
approved these changes
Mar 19, 2025
|
@aWN4Y25pa2EK could you just lint pls 🙏🏻 |
|
Just do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTT Measurement Feature for Bootstrapper Connections
Overview
This PR enhances the
cel-shed p2p connect-bootstrapperscommand with Round-Trip Time (RTT) measurement capabilities. The new functionality allows users to assess network latency to bootstrapper nodes, helping identify optimal nodes for connection and diagnose potential network issues.Features Added
--ping-count: Number of ping attempts per bootstrapper (default: 5)--ping-interval: Interval between ping attempts (default: 500ms)--jsonflag for JSON-formatted output to facilitate programmatic consumption--detailedflag displays individual ping attempt resultsImplementation Details
p2p.Module.Ping()method to measure RTTExample Usage
JSON Output
[ { "peer_id": "12D3KooWE3fmRtHgfk9DCuQFfY3H3JYEnTU3xZozv1Xmo8KWrWbK", "address": "da-full-2.celestia-bootstrap.net", "count": 5, "success": 5, "failed": 0, "min": "28.412834ms", "max": "38.056417ms", "average": "31.12545ms", "median": "29.939958ms", "std_dev": "3.538119ms" }, { "peer_id": "12D3KooWSqZaLcn5Guypo2mrHr297YPJnV8KMEMXNjs3qAS8msw8", "address": "da-bridge-1.celestia-bootstrap.net", "count": 5, "success": 5, "failed": 0, "min": "29.239291ms", "max": "50.791625ms", "average": "37.568741ms", "median": "30.707834ms", "std_dev": "9.626791ms" }, { "peer_id": "12D3KooWBBzzGy5hAHUQVh2vBvL25CKwJ7wbmooPcz4amQhzJHJq", "address": "boot.celestia.pops.one", "count": 5, "success": 5, "failed": 0, "min": "103.188459ms", "max": "105.453333ms", "average": "104.175441ms", "median": "103.888208ms", "std_dev": "940.113µs" }, { "peer_id": "12D3KooWAzucnC7yawvLbmVxv53ihhjbHFSVZCsPuuSzTg6A7wgx", "address": "celestia.qubelabs.io", "count": 5, "success": 5, "failed": 0, "min": "18.597333ms", "max": "22.830333ms", "average": "20.110383ms", "median": "19.714042ms", "std_dev": "1.440167ms" }, { "peer_id": "12D3KooWKZCMcwGCYbL18iuw3YVpAZoyb1VBGbx9Kapsjw3soZgr", "address": "da-full-1.celestia-bootstrap.net", "count": 5, "success": 5, "failed": 0, "min": "27.265291ms", "max": "28.821958ms", "average": "28.426941ms", "median": "28.76025ms", "std_dev": "591.358µs" }, { "peer_id": "12D3KooWQpuTFELgsUypqp9N4a1rKBccmrmQVY8Em9yhqppTJcXf", "address": "da-bridge-2.celestia-bootstrap.net", "count": 5, "success": 5, "failed": 0, "min": "27.443291ms", "max": "31.27ms", "average": "29.419524ms", "median": "29.70975ms", "std_dev": "1.313413ms" } ]Standard Output