-
Notifications
You must be signed in to change notification settings - Fork 991
feat!(share/shwap): implement get range request over shwap #4156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
==========================================
- Coverage 44.83% 44.72% -0.12%
==========================================
Files 265 313 +48
Lines 14620 24404 +9784
==========================================
+ Hits 6555 10914 +4359
- Misses 7313 12252 +4939
- Partials 752 1238 +486 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Discussed with the team. Below are clarifications addressing previously raised concerns and the subsequent next steps for this PR:
It is possible to verify inclusion directly against the DataRoot, bypassing the first step entirely. This adjustment will eliminate the need to store the row root hash within the proof structure. Achieving this will require minimal modifications in the NMT repository to support constructing the row root from Proof + Data. Once NMT support is available, this repository will also require updates to adopt the new verification algorithm. |
NMT repo feature required for this PR: |
This PR enables GetRangeRequests over the shwap by introducing the GetRangeNamespaceData container. It allows users to retrieve namespace data using ODS coordinates [from; to]. The user must specify the type of response they want:
Data + Proofs;
ProofsOnly;
The returned proof can be verified against the data root.