feat(state/core_accessor): add fee estimator #4168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
added
area:state
cristaloleg
requested review from
renaynay,
Wondertan,
vgonkivs and
walldiss
as code owners
cristaloleg
changed the title
renaynay
previously approved these changes
Mar 12, 2025
renaynay
previously approved these changes
Mar 13, 2025
vgonkivs
reviewed
Mar 19, 2025
|
this doesn't impact PFBs??
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4087
Implementation of the #4048
This PR enables third-party estimation for the submit transactions in the node(besides PFB). By default, fee estimation relies on the consensus node to which the node is connected. But the user can now provide a non-default endpoint, so the node will query gas price and gas from it. It can be provided via cli(using "core.estimator.address"). The address will be added to the node's config as
FeeEstimatorAddress.Additionally, the user can now provide a
maxGasPricefor every submit tx(viamax.gas.priceflag)- the max price that the user is willing to pay for the transaction. The transaction will not be submitted in case when estimated gas price exceeds themaxGasPrice(default:minGasPrice * 100)