Skip to content

refactor: use time.DateTime constant from standard library #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

threehonor
Copy link
Contributor

@threehonor threehonor commented Mar 25, 2025

The new time.DateTime constant added in Go 1.20 can improve code readability.

@github-actions github-actions bot added the external Issues created by non node team members label Mar 25, 2025
@cristaloleg cristaloleg added the kind:refactor Attached to refactoring PRs label Mar 25, 2025
@cristaloleg cristaloleg changed the title refactor: use constant time.DateTime built into the standard library refactor: use time.DateTime constant from standard library Mar 25, 2025
@cristaloleg cristaloleg enabled auto-merge (squash) March 25, 2025 15:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.72%. Comparing base (2469e7a) to head (3fa2990).
Report is 470 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/p2p/cmd/p2p.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4184      +/-   ##
==========================================
- Coverage   44.83%   44.72%   -0.12%     
==========================================
  Files         265      311      +46     
  Lines       14620    22892    +8272     
==========================================
+ Hits         6555    10238    +3683     
- Misses       7313    11541    +4228     
- Partials      752     1113     +361     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cristaloleg cristaloleg merged commit ee9148a into celestiaorg:main Mar 26, 2025
27 of 29 checks passed
quantix9 pushed a commit to quantix9/celestia-node that referenced this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants