fix(pruner): change header -> blocks in logs #4194
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4194 +/- ##
==========================================
- Coverage 44.83% 44.82% -0.01%
==========================================
Files 265 311 +46
Lines 14620 22892 +8272
==========================================
+ Hits 6555 10262 +3707
- Misses 7313 11523 +4210
- Partials 752 1107 +355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cristaloleg
reviewed
Apr 8, 2025
| @@ -117,7 +117,7 @@ func (s *Service) run() { | |||
|
|
|||
| lastPrunedHeader, err := s.lastPruned(s.ctx) | |||
| if err != nil { | |||
| log.Errorw("failed to get last pruned header", "height", s.checkpoint.LastPrunedHeight, | |||
| log.Errorw("failed to get last pruned block", "height", s.checkpoint.LastPrunedHeight, | |||
There was a problem hiding this comment.
But lastPrunedHeader is a header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would confuse users when we have header pruning