Skip to content

fix(rpc/client): handle empty auth token #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

fix(rpc/client): handle empty auth token #4197

merged 1 commit into from
Apr 4, 2025

Conversation

eshaan7
Copy link
Contributor

@eshaan7 eshaan7 commented Apr 4, 2025

Fixes #4196.

@github-actions github-actions bot added the external Issues created by non node team members label Apr 4, 2025
@cristaloleg cristaloleg added the kind:fix Attached to bug-fixing PRs label Apr 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.79%. Comparing base (2469e7a) to head (df76a67).
Report is 473 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4197      +/-   ##
==========================================
- Coverage   44.83%   44.79%   -0.05%     
==========================================
  Files         265      311      +46     
  Lines       14620    22895    +8275     
==========================================
+ Hits         6555    10255    +3700     
- Misses       7313    11530    +4217     
- Partials      752     1110     +358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

walldiss
walldiss approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@renaynay renaynay merged commit 3032150 into celestiaorg:main Apr 4, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walldiss walldiss walldiss approved these changes

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

Assignees

@eshaan7 eshaan7

Labels
external Issues created by non node team members kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty token is not handled in RPC client
5 participants
@eshaan7 @codecov-commenter @walldiss @renaynay @cristaloleg