fix: increase receive size limit for grpc #4206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
cristaloleg
reviewed
Apr 11, 2025
| @@ -63,6 +63,7 @@ func grpcClient(lc fx.Lifecycle, cfg Config) (*grpc.ClientConn, error) { | |||
| opts = append(opts, | |||
| grpc.WithUnaryInterceptor(retryInterceptor), | |||
| grpc.WithStreamInterceptor(retryStreamInterceptor), | |||
| grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(128*1024*1024)), | |||
There was a problem hiding this comment.
This gonna be overwritten on line 80 below. Isn't it?
There was a problem hiding this comment.
We have a const defined on line 33. Feel free to update it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure where this actually needs to be added or which branch for mamo, but I think in order to download 128MiB blocks we need this so figured I'd open. Please feel free to edit the target branch, this branch, close merge etc