Skip to content

fix!(store/metrics): fix metrics prefix #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

fix!(store/metrics): fix metrics prefix #4211

merged 2 commits into from
Apr 11, 2025

Conversation

vgonkivs
Copy link
Member

Self-explanatory

@vgonkivs vgonkivs added the kind:fix Attached to bug-fixing PRs label Apr 11, 2025
@vgonkivs vgonkivs self-assigned this Apr 11, 2025
@vgonkivs vgonkivs enabled auto-merge (squash) April 11, 2025 10:34
renaynay
renaynay previously approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utack

renaynay
renaynay reviewed Apr 11, 2025
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be technically breaking btw even if it's a fix

@vgonkivs vgonkivs changed the title fix(store/metrics): fix metrics prefix fix!(store/metrics): fix metrics prefix Apr 11, 2025
@vgonkivs
Copy link
Member Author

I'll add the breaking label then

@vgonkivs vgonkivs added the kind:break! Attached to breaking PRs label Apr 11, 2025
Wondertan
Wondertan previously approved these changes Apr 11, 2025
View reviewed changes
@vgonkivs vgonkivs dismissed stale reviews from Wondertan and renaynay via 264f34f April 11, 2025 11:02
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.65%. Comparing base (2469e7a) to head (264f34f).
Report is 483 commits behind head on main.

Files with missing lines Patch % Lines
store/cache/metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4211      +/-   ##
==========================================
- Coverage   44.83%   44.65%   -0.19%     
==========================================
  Files         265      312      +47     
  Lines       14620    22963    +8343     
==========================================
+ Hits         6555    10253    +3698     
- Misses       7313    11585    +4272     
- Partials      752     1125     +373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Wondertan
Wondertan approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if there is a linter which could check this

@vgonkivs vgonkivs merged commit 458e0dd into celestiaorg:main Apr 11, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay left review comments

@cristaloleg cristaloleg cristaloleg approved these changes

@Wondertan Wondertan Wondertan approved these changes

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@vgonkivs vgonkivs

Labels
kind:break! Attached to breaking PRs kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vgonkivs @codecov-commenter @cristaloleg @Wondertan @renaynay