Skip to content

feat(p2p): support autotls using IP shipyard #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

koenmtb1
Copy link
Contributor

Adding support for autotls as discussed in #4203

Some work to be done

  • Add tests
  • Align on approach
  • Write docs

@github-actions github-actions bot added the external Issues created by non node team members label Apr 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 20.58824% with 54 lines in your changes missing coverage. Please review.

Project coverage is 44.67%. Comparing base (2469e7a) to head (3a5b328).
Report is 484 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/p2p/autotls.go 0.00% 28 Missing ⚠️
nodebuilder/p2p/flags.go 0.00% 13 Missing ⚠️
nodebuilder/p2p/tls.go 50.00% 8 Missing ⚠️
nodebuilder/init.go 25.00% 2 Missing and 1 partial ⚠️
nodebuilder/store.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4212      +/-   ##
==========================================
- Coverage   44.83%   44.67%   -0.17%     
==========================================
  Files         265      313      +48     
  Lines       14620    23027    +8407     
==========================================
+ Hits         6555    10287    +3732     
- Misses       7313    11619    +4306     
- Partials      752     1121     +369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants