Skip to content

fix: close stats file on write error#4967

Merged
ninabarbakadze merged 8 commits into
celestiaorg:mainfrom
Radovenchyk:patch-2
May 12, 2026
Merged

fix: close stats file on write error#4967
ninabarbakadze merged 8 commits into
celestiaorg:mainfrom
Radovenchyk:patch-2

Conversation

@Radovenchyk
Copy link
Copy Markdown

@Radovenchyk Radovenchyk commented Apr 24, 2026

Add defer to ensure file descriptor is released on write error


Open in Devin Review

@Radovenchyk Radovenchyk requested a review from a team as a code owner April 24, 2026 08:26
@github-actions github-actions Bot added the external Issues created by non node team members label Apr 24, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review

Comment thread libs/edssser/edssser.go Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.84%. Comparing base (2469e7a) to head (a639fc3).
⚠️ Report is 787 commits behind head on main.

Files with missing lines Patch % Lines
libs/edssser/edssser.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4967      +/-   ##
==========================================
- Coverage   44.83%   35.84%   -8.99%     
==========================================
  Files         265      307      +42     
  Lines       14620    21016    +6396     
==========================================
+ Hits         6555     7534     +979     
- Misses       7313    12484    +5171     
- Partials      752      998     +246     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgonkivs
Copy link
Copy Markdown
Member

vgonkivs commented May 7, 2026

Hello @Radovenchyk. Do you mind to fix lint issues please?

@Radovenchyk
Copy link
Copy Markdown
Author

Hello @vgonkivs done

@Radovenchyk
Copy link
Copy Markdown
Author

@ninabarbakadze @vgonkivs Could you please re-run CI or confirm this is unrelated to the changes?

@ninabarbakadze ninabarbakadze added this pull request to the merge queue May 12, 2026
Merged via the queue into celestiaorg:main with commit 1016cc3 May 12, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external Issues created by non node team members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants