fix(shrex/peers): bound blacklisted hashes with an LRU cache#5058
Open
neyy91 wants to merge 1 commit into
Open
fix(shrex/peers): bound blacklisted hashes with an LRU cache#5058neyy91 wants to merge 1 commit into
neyy91 wants to merge 1 commit into
Conversation
The peer manager stored blacklisted datahashes in a plain map that was never pruned, so it grew for the entire lifetime of a node. A peer broadcasting shrexsub notifications with arbitrary invalid datahashes could drive unbounded memory growth. Replace the map with a fixed-size LRU cache. The blacklist is a best-effort spam filter, so evicting the least-recently-used entries is acceptable. Closes celestiaorg#1926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The peer manager stored blacklisted datahashes in a plain
map[string]boolthat was never pruned, so it grew for the entire lifetime of a node. A peer broadcasting shrexsub notifications with arbitrary invalid datahashes (the only gates inValidateare the blacklist checks and a height floor — neither stops new unique hashes) could drive unbounded memory growth.Replace the map with a fixed-size LRU cache (
hashicorp/golang-lru/v2, already a dependency). The blacklist is a best-effort spam filter, so evicting the least-recently-used entries is acceptable.Adds a regression test asserting the cache stays bounded after inserting far more than its capacity.
Closes #1926