feat: add validator announce, multisig ISM deployment, and local-doma…#266
feat: add validator announce, multisig ISM deployment, and local-doma…#266
Conversation
…in parameter This commit combines two feature additions to the Hyperlane CLI tool: 1. Validator Announce and Multisig ISM Deployment: - Added deployment command for MerkleRootMultisigIsm with validator addresses and threshold - Added validator announcement command for signature storage location - Added helper functions for parsing ISM IDs and validators from events 2. Local Domain Parameter: - Added local-domain as a configurable parameter for deployment commands - Updated SetupWithIsm to accept dynamic local-domain instead of hardcoded value - Applied to deploy-zkism, deploy-noopism, and deploy-multisigism commands Co-Authored-By: 0xwalid <walid.wah@gmail.com>
Update scripts, README, and code documentation to reflect the new local-domain parameter added to deployment commands. This ensures backward compatibility is maintained by updating all call sites. Changes: - Update docker-entrypoint.sh to pass local-domain (69420) to deploy-noopism - Update README.md with all three deployment command signatures - Update doc.go with comprehensive command documentation Co-Authored-By: 0xwalid <walid.wah@gmail.com>
|
@damiannolan I'm merging Walid changes from XO here. |
|
@damiannolan This PR is conflicting with our Rust fix for the ISM deployment #259. The Hyp client didn't correctly set the trusted height and root for EVM, Celestia so we instead added the ISM deploy and update functionality to ev-prover's CLI. |
understood will port this logic to this then |
| # Deploy with Multisig ISM | ||
| hyp deploy-multisigism 127.0.0.1:9090 [validators-comma-separated] [threshold] 69420 |
There was a problem hiding this comment.
Maybe it would be good to add here that the validators list should be eth-style 20 byte 0x hex addresses.
|
@blasrodri did you say there's more to be pushed to this PR before its ready? Lemme know when I should review :) |
Yes. Everything will be implemented in rust. I'll ping you when it's ready |
|
In rust? You mean Go, right? |
No. @jonas089 referred to the integration of some of these commands onto the |
|
Yes, there was a nuanced issue with instantiating the zk ism from the IMO I think the its good ux to be able to instantiate the zk ism from the |
|
Close in favor of #285 |
…in parameter
This commit combines two feature additions to the Hyperlane CLI tool:
Validator Announce and Multisig ISM Deployment:
Local Domain Parameter:
Overview