Conversation
Member
|
Please make sure to make the title of the PR clearer before you make it ready for review :) something like chore is more appropriate here |
jonas089
changed the title
jonas089
changed the title
jonas089
changed the title
jonas089
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the prover service to celestia-app v7, which includes the ZKISM merge.
Currently, the Docker image is pointed to local. This should be locked to a specific SHA once the setup is finalized.
For testing, this uses a build of celestia-app main from Jan 24 (post forwarding & ZKISM merge). There is no official release tag or Docker hash available yet.
This depends on celestiaorg/lumina#877, which adds v7 support to Lumina. That PR should be merged first.
celestiaorg/lumina#877
Until then, this PR points to jonas089/lumina, which contains the required v7 types.
Without these changes, using the latest celestia-app image results in a version validation error.