feat: update docs for v0.26.x celestia-node#2263
Conversation
Summary of ChangesHello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to reflect changes in configuration parameters for Celestia Node v0.26.x, specifically replacing DASer.SampleFrom with Header.Syncer.SyncFromHeight and Header.TrustedHash with Header.Syncer.SyncFromHash. The changes are applied consistently across celestia-node-trusted-hash.md and quick-start.md. A new section on 'Historical queries' has been added to explain the purpose of these new fields, which is a great addition for users. My review includes a minor suggestion to correct the list numbering in quick-start.md for better readability.
| 1. Set `Header.Syncer.SyncFromHeight` to the trusted height (e.g. `SyncFromHeight = 123456`) | ||
| 1. Set `Header.Syncer.SyncFromHash` to the trusted hash (e.g. `SyncFromHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` ) |
There was a problem hiding this comment.
For better readability and to follow standard markdown list formatting, please use sequential numbering for list items. The items in this sub-list should be numbered 2. and 3. respectively.
Note that the parent list item on line 85 is also numbered 1. but should be 2.. This is outside the changed lines, so it's just a suggestion for a future change.
| 1. Set `Header.Syncer.SyncFromHeight` to the trusted height (e.g. `SyncFromHeight = 123456`) | |
| 1. Set `Header.Syncer.SyncFromHash` to the trusted hash (e.g. `SyncFromHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` ) | |
| 2. Set `Header.Syncer.SyncFromHeight` to the trusted height (e.g. `SyncFromHeight = 123456`) | |
| 3. Set `Header.Syncer.SyncFromHash` to the trusted hash (e.g. `SyncFromHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` ) |
|
Overview
Resolves #2250