Skip to content

feat: update docs for v0.26.x celestia-node#2263

Merged
jcstein merged 3 commits intomainfrom
jcs/trusted-hash
Oct 7, 2025
Merged

feat: update docs for v0.26.x celestia-node#2263
jcstein merged 3 commits intomainfrom
jcs/trusted-hash

Conversation

@jcstein
Copy link
Copy Markdown
Member

@jcstein jcstein commented Oct 7, 2025

Overview

Resolves #2250

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the celestia-node documentation to reflect changes introduced in version v0.26.x. It primarily focuses on revising the configuration parameters used for setting trusted height and hash in light nodes, and clarifies how historical data queries are now handled, providing guidance on how to configure nodes to retain this functionality. These changes ensure the documentation accurately reflects the current behavior and configuration options of the node software.

Highlights

  • Configuration Parameter Updates: The documentation has been updated to reflect new configuration parameter names for setting trusted height and hash in celestia-node. DASer.SampleFrom is now Header.Syncer.SyncFromHeight, and Header.TrustedHash is now Header.Syncer.SyncFromHash.
  • Sed Command Adjustments: The sed commands provided in the guides for both macOS and Linux users have been updated to correctly target the new configuration parameter names.
  • Historical Queries Clarification: A new section has been added to explain that default light nodes no longer support historical queries and to provide guidance on how to configure nodes using the new Header.Syncer.SyncFromHeight and Header.Syncer.SyncFromHash parameters to retain this functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect changes in configuration parameters for Celestia Node v0.26.x, specifically replacing DASer.SampleFrom with Header.Syncer.SyncFromHeight and Header.TrustedHash with Header.Syncer.SyncFromHash. The changes are applied consistently across celestia-node-trusted-hash.md and quick-start.md. A new section on 'Historical queries' has been added to explain the purpose of these new fields, which is a great addition for users. My review includes a minor suggestion to correct the list numbering in quick-start.md for better readability.

Comment on lines +87 to +88
1. Set `Header.Syncer.SyncFromHeight` to the trusted height (e.g. `SyncFromHeight = 123456`)
1. Set `Header.Syncer.SyncFromHash` to the trusted hash (e.g. `SyncFromHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` )
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to follow standard markdown list formatting, please use sequential numbering for list items. The items in this sub-list should be numbered 2. and 3. respectively.

Note that the parent list item on line 85 is also numbered 1. but should be 2.. This is outside the changed lines, so it's just a suggestion for a future change.

Suggested change
1. Set `Header.Syncer.SyncFromHeight` to the trusted height (e.g. `SyncFromHeight = 123456`)
1. Set `Header.Syncer.SyncFromHash` to the trusted hash (e.g. `SyncFromHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` )
2. Set `Header.Syncer.SyncFromHeight` to the trusted height (e.g. `SyncFromHeight = 123456`)
3. Set `Header.Syncer.SyncFromHash` to the trusted hash (e.g. `SyncFromHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` )

@jcstein jcstein merged commit 9f25eea into main Oct 7, 2025
7 of 8 checks passed
@jcstein jcstein deleted the jcs/trusted-hash branch October 7, 2025 20:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-07 20:22 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: v0.26.x+ celestia-node - to query historical height, use SyncFromHeight or the SyncFromHash - update trusted hash guide

1 participant