Skip to content

Update celestia-node-trusted-hash.md#2265

Merged
jcstein merged 1 commit intomainfrom
jcstein-patch-2
Oct 9, 2025
Merged

Update celestia-node-trusted-hash.md#2265
jcstein merged 1 commit intomainfrom
jcstein-patch-2

Conversation

@jcstein
Copy link
Copy Markdown
Member

@jcstein jcstein commented Oct 9, 2025

Overview

@jcstein jcstein merged commit 1f45e53 into main Oct 9, 2025
5 of 6 checks passed
@jcstein jcstein deleted the jcstein-patch-2 branch October 9, 2025 17:56
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the readability and information hierarchy of the celestia-node-trusted-hash.md documentation. By moving the 'Historical queries' section, the changes ensure that critical information regarding light node behavior and configuration for historical data access is presented earlier, making it more accessible and impactful for users consulting the guide.

Highlights

  • Documentation Structure: The 'Historical queries' section in the celestia-node-trusted-hash.md guide has been relocated to an earlier, more prominent position within the document.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the structure of the celestia-node-trusted-hash.md guide by moving the 'Historical queries' section to a more logical position. This change provides better context for the user by explaining the 'why' before the 'how'. I've added one suggestion to improve the phrasing for clarity and consistency within the new section.

This is, however, temporary, and lazy header fetching will be available with Backward Sync.
:::

To retain the ability to request older queries with light nodes, use the new configuration fields to set an absolute header that the node will sync from:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better clarity and conciseness, this sentence can be rephrased. Using 'perform historical queries' is more consistent with the section title and the warning message. Also, describing the configuration as setting a 'specific starting block' is more precise than 'an absolute header', as both a height and a hash are configured.

Suggested change
To retain the ability to request older queries with light nodes, use the new configuration fields to set an absolute header that the node will sync from:
To perform historical queries with a light node, configure it to sync from a specific starting block by setting the following fields:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-09 17:57 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant