Skip to content

Conversation

@dn10-sanger
Copy link

This PR includes a new nf-core module for nf_xenium_feature_extraction pipeline wrapping the harmonise_xenium.py script as a Nextflow process.

Summary:

  • Integrates the harmonise_xenium.py script within a reproducible Nextflow module.
  • Edited main.nf and main.nf.test to support the new wrapper module.
  • Added nf-test.config, modules.config, and nextflow.config.

queue = 'normal'
group = 'cellgeni'
cpus = 1
clusterOptions = '-M 8G -R "select[mem>8G] rusage[mem=8G]"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just use the "memory". e.g. "memory = 8.GB"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hardcoded this because when using the 'memory', the nf-test.config and tests/nextflow.config files were possibly overriding the configuration from modules.config, which was causing the test to exit with a memory error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... but you don't have to use clusteroptions flag, right?
I meant it can be just memory = 8.Gb

group = 'cellgeni'
cpus = 1
clusterOptions = '-M 8G -R "select[mem>8G] rusage[mem=8G]"'
container = '/nfs/cellgeni/singularity/images/palom_tiledb.sif'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really required to explicitely declare here I'd say

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed & pushed now.


input[0] = [
'xeniumharmonise_test', // meta map
'/lustre/scratch127/cellgen/cellgeni/dn10/BK30-SKI-27-FO-3-S3/0043607 - BK30-SKI-27-FO-3-s3 - 2024-10-23 11.28.38.ndpi',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how large are these images? Is it possible to upload to s3?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is just being used as a sample for testing the module, and the size is around 36M. Since it's only a sample image, I believe it would be possible to use any other image which we can either upload to S3 or use the one already uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants