-
Notifications
You must be signed in to change notification settings - Fork 0
nf-core wrapper module for harmonise_xenium.py (nf_xenium_feature_extraction) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| queue = 'normal' | ||
| group = 'cellgeni' | ||
| cpus = 1 | ||
| clusterOptions = '-M 8G -R "select[mem>8G] rusage[mem=8G]"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just use the "memory". e.g. "memory = 8.GB"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hardcoded this because when using the 'memory', the nf-test.config and tests/nextflow.config files were possibly overriding the configuration from modules.config, which was causing the test to exit with a memory error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... but you don't have to use clusteroptions flag, right?
I meant it can be just memory = 8.Gb
| group = 'cellgeni' | ||
| cpus = 1 | ||
| clusterOptions = '-M 8G -R "select[mem>8G] rusage[mem=8G]"' | ||
| container = '/nfs/cellgeni/singularity/images/palom_tiledb.sif' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really required to explicitely declare here I'd say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been removed & pushed now.
|
|
||
| input[0] = [ | ||
| 'xeniumharmonise_test', // meta map | ||
| '/lustre/scratch127/cellgen/cellgeni/dn10/BK30-SKI-27-FO-3-S3/0043607 - BK30-SKI-27-FO-3-s3 - 2024-10-23 11.28.38.ndpi', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how large are these images? Is it possible to upload to s3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is just being used as a sample for testing the module, and the size is around 36M. Since it's only a sample image, I believe it would be possible to use any other image which we can either upload to S3 or use the one already uploaded.
This PR includes a new nf-core module for
nf_xenium_feature_extractionpipeline wrapping theharmonise_xenium.pyscript as a Nextflow process.Summary:
harmonise_xenium.pyscript within a reproducible Nextflow module.main.nfandmain.nf.testto support the new wrapper module.nf-test.config,modules.config, andnextflow.config.