feat: add --extraTxs flag to make-release and verify-deployed#11729
feat: add --extraTxs flag to make-release and verify-deployed#11729martinvol wants to merge 2 commits intorelease/core-contracts/16from
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8f59533fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const releaseProposal = proposal.filter( | ||
| (tx) => !extraTxs.some((extra) => JSON.stringify(extra) === JSON.stringify(tx)) | ||
| ) |
There was a problem hiding this comment.
releaseProposal is built by removing every proposal transaction that deep-equals an entry in extraTxs, regardless of where it appears or how many times it appears. This means any matching transaction outside the appended extra-tx tail (for example, an accidentally duplicated non-release tx in the main release section) is also excluded from assertValidProposalTransactions, so the validation can pass even though the proposal still contains disallowed transactions. Filter by appended position/count (suffix semantics) instead of global value matching.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dded399c1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assertValidProposalTransactions(releaseProposal) | ||
| assertValidInitializationData(artifacts, proposal, chainLookup, initializationData) |
There was a problem hiding this comment.
The new --extraTxs flow only removes appended transactions for assertValidProposalTransactions, but assertValidInitializationData still runs on the full proposal. If an appended extra tx uses _setAndInitializeImplementation (for example, for a non-release proxy), verification still fails with missing initialization data or missing artifact errors, which contradicts the script’s documented intent to skip validation for appended extra txs. Pass the filtered proposal (or otherwise subtract extraTxs) into initialization validation as well.
Useful? React with 👍 / 👎.
1 participant
Summary
-e/--extraTxsflag tomake-release-foundry.shandverify-deployed-forge.shreleaseData/extraTransactions/) is appended to the end ofproposal.jsonassertValidProposalTransactionsso they don't fail validation