Vulkan: several fixes and refactors #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
goeiecool9999
commented
Mar 22, 2024
•
goeiecool9999
commented
- make surfaces entirely managed by SwapchainInfoVK (and actually destroy the surfaces in destructor)
- destroy temporary surface for device enumeration
- simplify SwapchainInfoVk constructor
- change drawbackbuffer render pass load operation to OP_LOAD, so that when the swapchain image was cleared the black background is kept (formally, it always was in practice)
- fix structure type enum
- move queue family code back into VulkanRenderer
* make surfaces entirely managed by SwapchainInfoVK * destroy temporary surface for device enumeration * simplify SwapchainInfoVk constructor * change drawbackbuffer render pass load operation to OP_LOAD, so that when the swapchain image was cleared the black background is kept (formally, it always was in practice) * fix structure type enum * move queue family code back into VulkanRenderer
|
can we have "VK_KHR_synchronization2" as option in settings |
There isn't really a point to it being available as an option. The reason we want to use it is that it's just a tiny bit faster. But if we make the code path dynamic that introduces branching overhead and it would offset the benefit while also making the code a lot more complicated. |
|
On a side note including anything from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.