You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds implementation of _GetLocalIPAndSubnetMask for Linux. This allows LAN play in NEX games to work correctly. Previously, the fallback address was always used, which caused connection instability.
This is good.
I have one note. What if there are multiple IP addresses associated with the host? For example if the user is running virtual machines with libvirt it creates a bridge interface with a valid IP address. And when a VPN is running it also creates a virtual interface with an IP address associated with it. Often these interfaces will have a RFC 1918 address so we can't filter by that either.
It's possible that these virtual interfaces will appear later in the linked list because they're usually created later than the interfaces for the physical hardware, but I don't think the API explicitly guarantees that order and if so we probably shouldn't rely on it(?)
At least virtual VPN connections can be filtered by checking if the interface has the IFF_POINTOPOINT flag set though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds implementation of
_GetLocalIPAndSubnetMaskfor Linux. This allows LAN play in NEX games to work correctly. Previously, the fallback address was always used, which caused connection instability.