Skip to content

Add Stormshield SNMP mode properties#6113

Open
crsuser wants to merge 13 commits into
centreon:developfrom
crsuser:stormshield-snmp-mode-properties
Open

Add Stormshield SNMP mode properties#6113
crsuser wants to merge 13 commits into
centreon:developfrom
crsuser:stormshield-snmp-mode-properties

Conversation

@crsuser
Copy link
Copy Markdown

@crsuser crsuser commented Apr 9, 2026

Community contributors

Description

This pull request adds a new properties mode to the Stormshield SNMP plugin.

This mode allows monitoring of Stormshield device properties and configuration details via SNMP,
providing insights into device name, version information, and other key properties.

The mode has been:

  • Developed in network/stormshield/snmp/mode/properties.pm
  • Declared in network/stormshield/snmp/plugin.pm
  • Tested on the Centreon VM (CLI and UI)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

CLI Testing

perl centreon_plugins.pl --plugin=network::stormshield::snmp::plugin --mode=properties --hostname=<ip> --snmp-version=<version> --snmp-community=<community> --verbose

Output :

OK: Click to see more infos: ...
System Name: VM<obfuscated_name>
System node Name: None
Model: EVA1
Serial Number: VM<obfuscated_serial_number>
Version: <obfuscated_version>
Bios Version: VirtualBox
Date: 2026-04-09 13:58:08
Uptime: 0:2:59:1

UI Testing

  • Create a command check
  • Create a service, select your host(s), and the command you just created in the "Check Command" field
  • Export your poller and the service should appear in the Ressources Status tab
image

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

Summary by Aikido

Security Issues: 0 Quality Issues: 0 Resolved Issues: 0

🚀 New Features

  • Implemented new 'uptime' SNMP mode retrieving device properties and uptime

⚡ Enhancements

  • Registered new 'uptime' mode in Stormshield SNMP plugin

More info

@crsuser crsuser requested a review from a team as a code owner April 9, 2026 14:01
@crsuser crsuser requested a review from lucie-tirand April 9, 2026 14:01
@crsuser crsuser requested a review from a team as a code owner April 20, 2026 15:18
@crsuser crsuser force-pushed the stormshield-snmp-mode-properties branch from e55d9a6 to 07c8448 Compare April 21, 2026 07:40
@crsuser crsuser requested review from a team as code owners April 21, 2026 07:40
@crsuser crsuser force-pushed the stormshield-snmp-mode-properties branch from 07c8448 to 61a5e60 Compare April 21, 2026 07:41
@sc979 sc979 removed the request for review from a team April 23, 2026 13:14
@omercier
Copy link
Copy Markdown
Contributor

omercier commented Apr 27, 2026

Hi @crsuser,
Thanks for your proposition, but your pull request cannot be accepted yet.

Here are the main reasons:

  • Purpose
    • In its current state, your new mode does not monitor anything, it only displays information
    • It could be considered as monitoring if it handled thresholds to raise warning/critical alerts when the uptime is too low, for example. In that case it should be renamed uptime.pm and you could still display the other part of the information in the output.
  • Coding style
    • It does not comply with our coding style guidelines.
    • I strongly suggest you to take inspiration from this mode as it will show you how to monitor the uptime and at the same time display textual information. In this example it displays the sysDesc, which is a string decribing the system.
  • Tests
    • To reduce the risks of causing regressions, we add automated tests for all the modes we add or modify.
    • In this perspective, we ask all our contributors to provide data to reproduce the behaviour of the plugins. To provide this data, just send us the result of the following command: snmpwalk -ObentU -v 2c -c your_community ip_address .1.3.6.1.4.1.11256. As it may contain sensitive data, we strongly encourage you to have a look at its content to make sure you're not leaking anything. If unsure, you may still send the file by e-mail at my login AT Centreon dot com.

Feel free to ask any questions!

Regards,

Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
@crsuser crsuser requested a review from omercier June 1, 2026 08:24
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Comment thread src/network/stormshield/snmp/mode/uptime.pm Outdated
Co-authored-by: omercier <32134301+omercier@users.noreply.github.com>
@crsuser crsuser requested a review from omercier June 2, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants