Skip to content

enh(database::mssql::plugin) Mode(failed-jobs): Added total_count, failed_count, success_count, retry_count, canceled_count, and running_count support to status threshold#6207

Open
scresto31 wants to merge 2 commits into
developfrom
CTOR-1334-plugin-database-mssql-mode-failed-jobs-verbose-doesnt-work
Open

enh(database::mssql::plugin) Mode(failed-jobs): Added total_count, failed_count, success_count, retry_count, canceled_count, and running_count support to status threshold#6207
scresto31 wants to merge 2 commits into
developfrom
CTOR-1334-plugin-database-mssql-mode-failed-jobs-verbose-doesnt-work

Conversation

@scresto31
Copy link
Copy Markdown
Contributor

Description

Plugin(database::mssql) - Mode(failed-jobs): Verbose doesn't work

Fixes # CTOR-1334

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

…_count, and running_count support to status threshold
@scresto31 scresto31 self-assigned this May 22, 2026
@scresto31 scresto31 requested a review from a team as a code owner May 22, 2026 13:40
@scresto31 scresto31 requested review from Evan-Adam and removed request for a team May 22, 2026 13:40
{ name => 'name' }, { name => 'status' },
{ name => 'runtime'}, { name => 'duration' }
{ name => 'runtime'}, { name => 'duration' },
{ name => 'failed_count' }, { name => 'success_count' },
Copy link
Copy Markdown

@aikido-pr-checks aikido-pr-checks Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status threshold context adds failed/success/retry/canceled/running counts but omits total_count, so %{total_count} cannot work despite being documented as supported.

Suggested change
{ name => 'failed_count' }, { name => 'success_count' },
{ name => 'total_count' }, { name => 'failed_count' }, { name => 'success_count' },
Details

✨ AI Reasoning
​The change aims to expose aggregate counters for status threshold evaluation. However, one documented variable is not actually injected into the threshold context. Since threshold evaluation only has access to declared values, that specific variable cannot work at runtime despite being advertised, creating a direct behavior/documentation contradiction introduced by this patch.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant