enh(database::mssql::plugin) Mode(failed-jobs): Added total_count, failed_count, success_count, retry_count, canceled_count, and running_count support to status threshold#6207
Conversation
…_count, and running_count support to status threshold
| { name => 'name' }, { name => 'status' }, | ||
| { name => 'runtime'}, { name => 'duration' } | ||
| { name => 'runtime'}, { name => 'duration' }, | ||
| { name => 'failed_count' }, { name => 'success_count' }, |
There was a problem hiding this comment.
The status threshold context adds failed/success/retry/canceled/running counts but omits total_count, so %{total_count} cannot work despite being documented as supported.
| { name => 'failed_count' }, { name => 'success_count' }, | |
| { name => 'total_count' }, { name => 'failed_count' }, { name => 'success_count' }, |
Details
✨ AI Reasoning
The change aims to expose aggregate counters for status threshold evaluation. However, one documented variable is not actually injected into the threshold context. Since threshold evaluation only has access to declared values, that specific variable cannot work at runtime despite being advertised, creating a direct behavior/documentation contradiction introduced by this patch.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Description
Plugin(database::mssql) - Mode(failed-jobs): Verbose doesn't work
Fixes # CTOR-1334
Type of change