Skip to content

Mon 15036 remove comma dangle in prettiers config 23 04#132

Closed
kduret wants to merge 4 commits into
developfrom
MON-migration-MON-15036-remove-comma-dangle-in-prettiers-config-23-04
Closed

Mon 15036 remove comma dangle in prettiers config 23 04#132
kduret wants to merge 4 commits into
developfrom
MON-migration-MON-15036-remove-comma-dangle-in-prettiers-config-23-04

Conversation

@kduret
Copy link
Copy Markdown
Contributor

@kduret kduret commented Nov 8, 2022

Description

  • Add eslint trailingComma rule
  • Fix EsLint errors due to these change

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@kduret
Copy link
Copy Markdown
Contributor Author

kduret commented Nov 8, 2022

migrated from https://github.com/centreon/centreon/pull/12033

@kduret kduret mentioned this pull request Nov 8, 2022
Draft
11 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 8, 2022

web-frontend-component-tests-report

1 tests   - 4   0 ✔️  - 5   0s ⏱️ -2s
1 suites  - 1   0 💤 ±0 
1 files   ±0   1 ❌ +1 

For more details on these failures, see this check.

Results for commit eb1aa6d. ± Comparison against base commit f043bee.

This pull request removes 5 and adds 1 tests. Note that renamed tests count towards both. 
displays the direct child items and highlights the item when hovered ‑ Navigation menu displays the direct child items and highlights the item when hovered
expands the menu when the logo is clicked ‑ Navigation menu expands the menu when the logo is clicked
highlights the menu item when double clicked ‑ Navigation menu highlights the menu item when double clicked
highlights the parent item when the item is clicked ‑ Navigation menu highlights the parent item when the item is clicked
matches the current snapshot "initial menu" ‑ Navigation menu matches the current snapshot "initial menu"

An uncaught error was detected outside of a test ‑ An uncaught error was detected outside of a test

sc979 added a commit to sc979/centreon that referenced this pull request Dec 12, 2022
@tuntoja @jeremyjaouen
@zguennoune02 @adr-mo @sc979 @chgautier @ataghzout @lpinsivy @hyahiaoui-ext
Rebase dev 22.04.x onto 22.04.x (centreon#147)
c4fb34c 
* chore(php version): fix warning (centreon#112)

* new workflow

* hotfixing jenkinsfile

* fix(comments): display correctly last comments (centreon#115)

* enh(chore): automate dependabot ticket creation (centreon#116)

* fix(chore): old dependabot's PR ticket creation (centreon#117)

* enh(feature-switch): fully manage feature switch (centreon#114)

* enh(feature-switch): fully manage feature switch

* fix(index): wrong variable used

* fix qabranch variable

* enh(chore): issueType, feature_team and issue description

* chore(version): prepare 22.04 serie (centreon#120)

* chore(version): prepare 22.04 serie

* Update Jenkinsfile

* fix(secu): add SQ pipeline timeout (centreon#128)

* fix(chore): use github action env usage (centreon#129)

* fix(build): disable centos8 packaging (centreon#130)

* fix(chore): dependabot github automation (centreon#131)

* alma8 enabled (centreon#132)

* feat(ui): Apply dark mode for widget host monitoring  (centreon#136)

* fix(css): fix ccs import (centreon#138)

* chore(version): prepare 22.04.next (centreon#140)

* Merge release-debian-22.04.0 into 22.04.x (centreon#145)

* fix debian

* Update Jenkinsfile

* Update Jenkinsfile

* add version check version of dependency and remove unused file

Co-authored-by: Zakaria GUENNOUNE <zguennoune@centreon.com>
Co-authored-by: Luiz Costa <me@luizgustavo.pro.br>

* enh(secu): update GPG key (centreon#126)

* fix(secu): change fingerprint key (centreon#127)

* Add configuration to build DEB package (centreon#137)

* add deb package

* fix project name

* fix package name

* fix package name

* add delivery

* fix : Issue with cross databases query when the name contains some characters (centreon#144)

Co-authored-by: jeremyjaouen <61694165+jeremyjaouen@users.noreply.github.com>
Co-authored-by: Zakaria Guennoune <zguennoune@centreon.com>
Co-authored-by: Adrien Morais <31647811+adr-mo@users.noreply.github.com>
Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com>
Co-authored-by: schapron <schapron@centreon.com>
Co-authored-by: Charles Gautier <33026375+chgautier@users.noreply.github.com>
Co-authored-by: ataghzout <97593248+ataghzout@users.noreply.github.com>
Co-authored-by: Laurent Pinsivy <lpinsivy@centreon.com>
Co-authored-by: Luiz Costa <me@luizgustavo.pro.br>
Co-authored-by: Zakaria Guennoune <83596451+zguennoune02@users.noreply.github.com>
Co-authored-by: hyahiaoui-ext <97593234+hyahiaoui-ext@users.noreply.github.com>
tuntoja pushed a commit that referenced this pull request Jan 4, 2023
@chgautier
alma8 enabled (#132)
04c63b4
@Med1233 Med1233 closed this Jan 17, 2023
@kduret kduret deleted the MON-migration-MON-15036-remove-comma-dangle-in-prettiers-config-23-04 branch January 17, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kduret @Med1233