Add is-live=false mode (Blocking v buffer creation on OnPaint) - #105
Open
aiden-jeffrey wants to merge 4 commits into
Open
Add is-live=false mode (Blocking v buffer creation on OnPaint)#105aiden-jeffrey wants to merge 4 commits into
aiden-jeffrey wants to merge 4 commits into
Conversation
Defaults to is-live=true (previous functionality)
aiden-jeffrey
force-pushed
the
aiden/raf-lock
branch
from
December 17, 2025 14:14
1cfe79a to
63e7978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We block
createon a freshOnPaintcall - effectively frame locking the cefsrc output to 1 frame per requestAnimationFrame on the browser side. This can be tested with http://localhost:9000/raf_test.html?audioDelay=-1. For example:NB: setting audioDelay=-1 in that test page turns off audio. This change doesn't play well with audio currently.
Note that as @MathieuDuponchelle suggested, this clogs up the audio side of things - I need to dig further into my audio PR to genuinely decouple the audio buffer creation from the video buffer creation.
Based on #104. So the actual diff is this commit.
There's also this commit - apparently we should return NO_PREROLL on state change to PAUSED https://gstreamer.freedesktop.org/documentation/additional/design/live-source.html?gi-language=c, but if we do this the pipeline never goes to playing.