Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt with grafana_network not grafana_server_addr (backport #7654) #7655

Open
wants to merge 1 commit into
base: stable-8.0
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 11, 2025

The networks list in a spec is usually a range not a single IP. grafana_server_addr is a fact created from grafana_network so it is a more appropriate parameter to pass.

Follow up to 770a527


This is an automatic backport of pull request #7654 done by Mergify.

@mergify mergify bot added the conflicts label Feb 11, 2025
Copy link
Author

mergify bot commented Feb 11, 2025

Cherry-pick of b1f7e2d has failed:

On branch mergify/bp/stable-8.0/pr-7654
Your branch is up to date with 'origin/stable-8.0'.

You are currently cherry-picking commit b1f7e2da.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   infrastructure-playbooks/cephadm-adopt.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@asm0deuz asm0deuz force-pushed the mergify/bp/stable-8.0/pr-7654 branch 2 times, most recently from 97620e2 to c157227 Compare February 11, 2025 13:13
@asm0deuz asm0deuz closed this Feb 11, 2025
@asm0deuz asm0deuz deleted the mergify/bp/stable-8.0/pr-7654 branch February 11, 2025 13:28
@asm0deuz asm0deuz restored the mergify/bp/stable-8.0/pr-7654 branch February 11, 2025 13:28
@fultonj
Copy link
Contributor

fultonj commented Feb 11, 2025

Why was this PR closed?

@asm0deuz asm0deuz reopened this Mar 18, 2025
@asm0deuz asm0deuz changed the title Adopt with grafana_network not grafana_server_addr (backport #7654) [skip ci] Adopt with grafana_network not grafana_server_addr (backport #7654) Mar 19, 2025
@asm0deuz asm0deuz force-pushed the mergify/bp/stable-8.0/pr-7654 branch from c157227 to d702a2c Compare March 19, 2025 14:59
@asm0deuz asm0deuz force-pushed the mergify/bp/stable-8.0/pr-7654 branch 5 times, most recently from 6db1e70 to 7108803 Compare March 19, 2025 22:10
@asm0deuz asm0deuz changed the title [skip ci] Adopt with grafana_network not grafana_server_addr (backport #7654) Adopt with grafana_network not grafana_server_addr (backport #7654) Mar 19, 2025
rgw daemons fail to start as they were looking for
ssl certificates while none were available.

Signed-off-by: Teoman ONAY <[email protected]>
(cherry picked from commit bf76bde)
@asm0deuz asm0deuz force-pushed the mergify/bp/stable-8.0/pr-7654 branch from 7108803 to 0f7b229 Compare March 19, 2025 22:11
Copy link

github-actions bot commented Apr 4, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants