ceph-dev-new-setup/build: cleanup *-debug branches #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matan-B
force-pushed
the
wip-matanb-cleanup-debug
branch
from
7bf4390 to
a88b80c
Compare
The newly introduced "debug" flavor from ceph#2497 can be used instead. Add "DWITH_CEPH_DEBUG_MUTEX" to preserve existing *-debug behavior. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan-B
force-pushed
the
wip-matanb-cleanup-debug
branch
from
8ad72d8 to
1fc5909
Compare
The only two flavors are default and debug. The debug case should apply additional flags on top of the defualt ones. There's no need for case switch. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan-B
force-pushed
the
wip-matanb-cleanup-debug
branch
from
1fc5909 to
968c537
Compare
Contributor
Author
|
Note, having a branch named *-debug would qualify as a default flavor. We might skip building containers for debug flavor soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the newly introduced "debug" flavor from #2497 can be used insead.