Skip to content

helm: allow setting priorityClassName on the operator deployment#452

Draft
rewantsoni wants to merge 1 commit intoceph:mainfrom
rewantsoni:prio-class
Draft

helm: allow setting priorityClassName on the operator deployment#452
rewantsoni wants to merge 1 commit intoceph:mainfrom
rewantsoni:prio-class

Conversation

@rewantsoni
Copy link
Copy Markdown
Contributor

@rewantsoni rewantsoni commented Apr 13, 2026

Describe what this PR does

Allow setting priorityClassName on operator deployment via controllerManager.priorityClassName

Related issues

Fixes: #450

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

allow setting priorityClassName on operator deployment via
`controllerManager.priorityClassName`

Signed-off-by: Rewant Soni <resoni@redhat.com>
@rewantsoni
Copy link
Copy Markdown
Contributor Author

Tested the changes by

helm template test deploy/charts/ceph-csi-operator/  --set controllerManager.priorityClassName=system-cluster-critical
---
# Source: ceph-csi-operator/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: test-ceph-csi-operator-controller-manager
  namespace: default
  labels:
  ...
spec:
  ...
  template:
    metadata:
    ...
    spec:
      containers:
      - args:
      ....
      serviceAccountName: test-ceph-csi-operator-controller-manager
      terminationGracePeriodSeconds: 10
      priorityClassName: system-cluster-critical

@rewantsoni rewantsoni marked this pull request as draft April 13, 2026 09:46
# -- Number of controller manager replicas (default: 1)
replicas: 1
# -- Priority class name for the controller manager pod (default: "")
priorityClassName: ""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rewantsoni how about adding empty value for manager.yaml will that works?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding empty value for priorityClassName would make the kubebuilder add the priorityClassName field to the bundle (deploy/all-in-one/install.yaml has the field), but one we helmify it the field it removed from the deployment.yaml (charts/ceph-csi-operator/deploymeny)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm: Allow setting priorityClassName

2 participants