helm: allow setting priorityClassName on the operator deployment#452
Draft
rewantsoni wants to merge 1 commit intoceph:mainfrom
Draft
helm: allow setting priorityClassName on the operator deployment#452rewantsoni wants to merge 1 commit intoceph:mainfrom
rewantsoni wants to merge 1 commit intoceph:mainfrom
Conversation
allow setting priorityClassName on operator deployment via `controllerManager.priorityClassName` Signed-off-by: Rewant Soni <resoni@redhat.com>
Contributor
Author
|
Tested the changes by |
Madhu-1
reviewed
Apr 15, 2026
| # -- Number of controller manager replicas (default: 1) | ||
| replicas: 1 | ||
| # -- Priority class name for the controller manager pod (default: "") | ||
| priorityClassName: "" |
Collaborator
There was a problem hiding this comment.
@rewantsoni how about adding empty value for manager.yaml will that works?
Contributor
Author
There was a problem hiding this comment.
Adding empty value for priorityClassName would make the kubebuilder add the priorityClassName field to the bundle (deploy/all-in-one/install.yaml has the field), but one we helmify it the field it removed from the deployment.yaml (charts/ceph-csi-operator/deploymeny)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Allow setting priorityClassName on operator deployment via
controllerManager.priorityClassNameRelated issues
Fixes: #450
Checklist:
guidelines in the developer guide.