rbd: set logger for the controller-runtime#5174
Merged
mergify[bot] merged 1 commit intoceph:develfrom Feb 25, 2025
Merged
Conversation
Rakshith-R
approved these changes
Feb 25, 2025
Madhu-1
approved these changes
Feb 25, 2025
Member
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 3e4e4ed |
Signed-off-by: Praveen M <m.praveen@ibm.com>
iPraveenParihar
force-pushed
the
fix/ctrl-runtime-set-logger
branch
from
fe69a7a to
13720de
Compare
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.30 |
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.31 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
The error message [controller-runtime] log.SetLogger(...) was never called; logs will not be displayed in
csi-omap-generatorsidecar means that the logging has not been properly set up. Because of this, log messages that controller-runtime logs will not be visible.To fix it, we need to explicitly set a logger for controller-runtime.
Fixes: #5165
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)