rbd: fix encrypted PVC with metadata KMS cannot be deleted (backport #5149)#5176
Merged
mergify[bot] merged 1 commit intorelease-v3.13from Feb 26, 2025
Merged
Conversation
Contributor
Author
|
Cherry-pick of 5b587c9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Zerotens <12968743+zerotens@users.noreply.github.com> (cherry picked from commit 5b587c9) # Conflicts: # PendingReleaseNotes.md
5a6aa04 to
0863c1b
Compare
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.31 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.29 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.30 |
nixpanic
approved these changes
Feb 25, 2025
Rakshith-R
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Creating an encrypted Persistent Volume Claim with reclaim policy Retain, the Persistent Volume cannot be deleted after the Namespace with the corresponding secret of the encrypted volume was deleted.
This fix moves the logic from the kms class initialization to the method where the encryption key is needed.
As the Delete Volume CSI request does not need or call the
FetchDEKmethod, the volume get's deleted successfully.Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Related issues
Fixes: #5148
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
This is an automatic backport of pull request #5149 done by [Mergify](https://mergify.com).