build: move e2e dependencies into e2e/go.mod#5188
Conversation
mergify
bot
added
component/testing
nixpanic
force-pushed
the
e2e-module
branch
2 times, most recently
from
ddc411b to
08805a0
Compare
| "time" | ||
|
|
||
| "github.com/ceph/ceph-csi/internal/util" | ||
| "github.com/ceph/ceph-csi/pkg/util/crypto" |
There was a problem hiding this comment.
This line should have been included in the previous commit.
|
If we do not have plans to use |
|
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
@nixpanic, all jobs have failed at the CephFS test I've seen this test case fail previously with mount-utils versions later than v0.29.3 (reference: #4633). To address this, I had added k8s.io/mount-utils v0.29.3 in the replace section, but it's missing from the main go.mod file, which I suspect is causing the failure. Could you try adding the replace directive in the main go.mod file and see if that resolves the issue? |
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Several packages are only used while running the e2e suite. These packages are less important to update, as the they can not influence the final executable that is part of the Ceph-CSI container-image. By moving these dependencies out of the main Ceph-CSI go.mod, it is easier to identify if a reported CVE affects Ceph-CSI, or only the testing (like most of the Kubernetes CVEs). Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
It is not clear why listing all modules is useful. Some modules have internal versions (Kubernetes modules), and the command reports those as a warning with an error exit code. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Thanks for the suggestion, @iPraveenParihar! The replacing of |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
Seems to pass with the old mount-utils package! |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 5e19ed5 |
5 participants
Several packages are only used while running the e2e suite. These
packages are less important to update, as the they can not influence the
final executable that is part of the Ceph-CSI container-image.
By moving these dependencies out of the main Ceph-CSI go.mod, it is
easier to identify if a reported CVE affects Ceph-CSI, or only the
testing (like most of the Kubernetes CVEs).