util: do not use mount-utils.IsLikelyNotMountPoint anymore#5203
util: do not use mount-utils.IsLikelyNotMountPoint anymore#5203mergify[bot] merged 2 commits intoceph:develfrom
mount-utils.IsLikelyNotMountPoint anymore#5203Conversation
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
@nixpanic we are using |
Sure, done! |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
Madhu-1
left a comment
Madhu-1
left a comment
There was a problem hiding this comment.
LGTM, if possible please see if you can address the nits.
`IsLikelyNotMountPoint()` is an optimized version for `IsMountPoint()` which can not detect all type of mounts (anymore). The slower `IsMountPoint()` is more safe to use. This can cause a slight performance regression in the case there are many mountpoints on the system, but correctness is more important than speed while mounting. Fixes: ceph#4633 Signed-off-by: Niels de Vos <ndevos@ibm.com>
The inverse checking and returning of is-a-mounted-path makes it difficult to understand the function. It is easier to follow the code when the function just returns what it says it does, hence added the comment for the function too. Some errors were returned directly, others were converted to gRPC errors. This has been corrected now too, and the caller converts the plain error to a gRPC error now. Signed-off-by: Niels de Vos <ndevos@ibm.com>
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 7f7988b |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
5 participants
IsLikelyNotMountPoint()is an optimized version forIsMountPoint()which can not detect all type of mounts (anymore). The slower
IsMountPoint()is more safe to use. This can cause a slightperformance regression in the case there are many mountpoints on the
system, but correctness is more important than speed while mounting.
Fixes: #4633