Skip to content

rbd: consider lastSyncTimeNotFound as image not syncing #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Aug 13, 2025
Merged

rbd: consider lastSyncTimeNotFound as image not syncing #5498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions internal/csi-addons/rbd/replication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,19 +716,32 @@ func (rs *ReplicationServer) ResyncVolume(ctx context.Context,
err.Error())
}

// If the savedImageTime is not empty,
// then the image might be in need of resync.
if savedImageTime != "" {
st, sErr := timestampFromString(savedImageTime)
if sErr != nil {
return nil, status.Errorf(codes.Internal, "failed to parse image creation time: %s", sErr.Error())
}
log.DebugLog(ctx, "image %s, savedImageTime=%v, currentImageTime=%v", rbdVol, st, creationTime)

// Fetch the last sync info from the local status in order
// to determine if the image is syncing or not.
syncInfo, sErr := localStatus.GetLastSyncInfo(ctx)
if sErr != nil {
if sErr != nil && !errors.Is(sErr, rbderrors.ErrLastSyncTimeNotFound) {
return nil, status.Errorf(codes.Internal, "failed to get last sync info: %s", sErr.Error())
}

if req.GetForce() && st.Equal(*creationTime) && !syncInfo.IsSyncing() {
// consider the image to be not syncing if either
// - the last sync time was not found
// or
// - the sync info indicates the image is not syncing
isNotSyncing := errors.Is(sErr, rbderrors.ErrLastSyncTimeNotFound) || !syncInfo.IsSyncing()

// image needs to be resynced if
// - force option is set
// - image creation time is equal to the saved image creation time
// - image is not already in syncing state
if req.GetForce() && st.Equal(*creationTime) && isNotSyncing {
err = mirror.Resync(ctx)
if err != nil {
return nil, getGRPCError(err)
Expand Down