fix(helm): fix invalid YAML syntax and nil pointer in values.yaml

[KeshavSoni2511]

The template check for domainLabels evaluates empty arrays as truthy,
causing an invalid --domainlabels= flag to be generated. Fix by
checking that the array is both defined and non-empty before generating
the flag.

Keep domainLabels: [] in values.yaml for better user experience -
users can uncomment example values without needing to add the array
syntax back."

[nixpanic]

Hi @KeshavSoni2511, thanks for the PR.

Instead of setting domainLabels to an empty array, I think it would be more userfriendly to add a check for in the template. Users may just uncomment values for domainLabels, and miss that it is set to an empty array by default.

Could you also have a look at these two things?

1. proper commit summary formatting (not fix(helm) but just helm)
2. validate that this problems isn't there in the CephFS Helm chart

Once the commit is modified, force-push it to your branch so that there is a single clean commit and it can get reviewed/tested/merged.

[iPraveenParihar]

@KeshavSoni2511 Can you address the commitlint and DCO CI failures?

[nixpanic]

Hi @KeshavSoni2511 ,

the only thing missing here is the Signed-off-by: Real Name <email@ddre.ss> in the commit. You can add that by git commit --amend -s your commit and make sure you accept the terms of contributing as described in the DCO. After that, git push --force origin the change again.

Thanks!

[KeshavSoni2511]

Hi @KeshavSoni2511 ,

the only thing missing here is the Signed-off-by: Real Name <email@ddre.ss> in the commit. You can add that by git commit --amend -s your commit and make sure you accept the terms of contributing as described in the DCO. After that, git push --force origin the change again.

Thanks!

Done, Please review

[KeshavSoni2511]

Gentle Reminder!!

[nixpanic]

/test ci/centos/mini-e2e-helm/k8s-1.35/rbd

[iPraveenParihar]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-03-31 14:09 UTC · Rule: default
• ✅ Checks started · in-place
• 🚫 Left the queue — 2026-03-31 20:08 UTC · at e5cb2770cdae656717054a603c042fa75439a91f

This pull request spent 5 hours 59 minutes 29 seconds in the queue, with no time running CI.

Required conditions to merge

• #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • fix(helm): fix invalid YAML syntax and nil pointer in values.yaml #5990
• #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • fix(helm): fix invalid YAML syntax and nil pointer in values.yaml #5990

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-04-01 07:47 UTC · Rule: default
• ✅ Checks skipped · PR is already up-to-date
• ✅ Merged — 2026-04-01 07:48 UTC · at e5cb2770cdae656717054a603c042fa75439a91f

This pull request spent 7 seconds in the queue, including 1 second running CI.

Required conditions to merge

• #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • fix(helm): fix invalid YAML syntax and nil pointer in values.yaml #5990
• #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • fix(helm): fix invalid YAML syntax and nil pointer in values.yaml #5990