chg: type it_infra_and_services meta_template IP as ipv4 - #234
Open
DocArmoryTech wants to merge 4 commits into
Open
chg: type it_infra_and_services meta_template IP as ipv4#234DocArmoryTech wants to merge 4 commits into
DocArmoryTech wants to merge 4 commits into
Conversation
All five fields in this template were typed `text`, so values matched as strings. Typed `ipv4`, IPv4Type::setQueryExpression matches by CIDR containment instead, which is what lets a stored range answer "which organisation owns this address?". Given the template exists specifically to "register the IP of part of the infrastructure or services", string matching forfeits most of its value. Version bumped 2 -> 3. This is a tightening change. Instances holding values that are not IPv4 -- hostnames, or IPv6 addresses stored in the absence of a v6 field -- will not update automatically: getMetaTemplateConflictsForMetaTemplate reports them as conflicting entities and blocks the automatic path, which is the intended behaviour for a stricter field. Operators resolve those before updating, and nothing is silently dropped. Two related points deliberately left out of this commit: whether matching ipv6 fields should be added, and the `Microsfot` typo, which cannot be corrected without discarding stored values because field names are matched by name on update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All five fields in this template were typed
text, so values matched asstrings. Typed
ipv4, IPv4Type::setQueryExpression matches by CIDRcontainment instead, which is what lets a stored range answer "which
organisation owns this address?".
Given the template exists specifically to "register the IP of part of the
infrastructure or services", string matching forfeits most of its value.
Version bumped 2 -> 3.
This is a tightening change. Instances holding values that are not IPv4 --
hostnames, or IPv6 addresses stored in the absence of a v6 field -- will not
update automatically: getMetaTemplateConflictsForMetaTemplate reports them as
conflicting entities and blocks the automatic path, which is the intended
behaviour for a stricter field. Operators resolve those before updating, and
nothing is silently dropped.
Two related points deliberately left out of this commit: whether matching
ipv6 fields should be added, and the
Microsfottypo, which cannot becorrected without discarding stored values because field names are matched
by name on update.