Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0 11 dev refine related resources #1426

Draft
wants to merge 5 commits into
base: v0-11-dev
Choose a base branch
from
Draft

V0 11 dev refine related resources #1426

wants to merge 5 commits into from

Conversation

lgebhardt
Copy link
Member

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt force-pushed the v0-11-dev_refine_related_resources branch from c829277 to dbfd061 Compare January 15, 2024 19:17
@lgebhardt lgebhardt force-pushed the v0-11-dev_refine_related_resources branch from dbfd061 to 0b60043 Compare January 24, 2024 18:44
@lgebhardt lgebhardt force-pushed the v0-11-dev_refine_related_resources branch from 0b60043 to c9202e7 Compare March 18, 2024 14:28
@lgebhardt
ignore test_db files
186ceff
@lgebhardt
Make options hash not optional
a7c0e4e
@lgebhardt
Move cache key generation inside caching section
9a9e917
@lgebhardt
Rename JoinManagers
16ee576
@lgebhardt
Allow related resources to be retrieved by inverse or primary on a pe…
29a43c3 
…r relationship basis

Add `find_related_through` to relationships with defaults controlled by the resource classes

Move find related fragments through primary methods to shared module to allow sharing between the default and v10 strategies
@lgebhardt lgebhardt force-pushed the v0-11-dev_refine_related_resources branch from c9202e7 to 29a43c3 Compare April 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lgebhardt