fix: remove edge case chance of SET ROLE leaking #122
Merged
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianBuzzo
force-pushed
the
lucianbuzzo/use-local-role
branch
from
4d6f6db to
9413541
Compare
Contributor
|
Published beta package version: |
LucianBuzzo
force-pushed
the
lucianbuzzo/use-local-role
branch
4 times, most recently
from
b38c52b to
41758a1
Compare
This changes removes the edge case chance that `SET ROLE` is never reset either by a rollback or `SET ROLE none`, by switching to `SET LOCAL ROLE` which will last only until the end of the current transaction. Whilst the scenario where the role leaks outside of the transaction without being reset correctly is extremely unlikely, and I am unable to create test scenario that replicates it, I think it is wise to future proof the code and make further guarantees that the leak cannot occur. See: - https://www.postgresql.org/docs/14/sql-set-role.html - https://www.postgresql.org/docs/14/sql-set.html
LucianBuzzo
force-pushed
the
lucianbuzzo/use-local-role
branch
from
41758a1 to
c9a8514
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes removes the edge case chance that
SET ROLEis never reset either by a rollback orSET ROLE none, by switching toSET LOCAL ROLEwhich will last only until the end of the current transaction.Whilst the scenario where the role leaks outside of the transaction without being reset correctly is extremely unlikely, and I am unable to create test scenario that replicates it, I think it is wise to future proof the code and make further guarantees that the leak cannot occur.
See: