namespace: fit-to-width attr popup and ":" goto-path#23
Merged
Conversation
The Edit Attribute popup was hardcoded to 72 columns, truncating long ACL values. Compute the popup width from the longest content line, capped at the terminal width. Add a ":" command in the namespace view that opens a "Go To Path" prompt. Input is resolved against the current directory: absolute paths replace the current path, relative paths are joined and cleaned.
The fit-to-width popup could stretch across the entire terminal when an attribute value (e.g. a long ACL or vtrace string) was several hundred characters wide. Cap the popup at 96 cells and hard-wrap long "key = value" entries onto continuation lines, indented to align under the value.
lobis
force-pushed
the
namespace-popup-fit-and-goto
branch
from
78ca44a to
58b5ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
key = valueentries hard-wrap onto continuation lines indented under the value, so the popup never stretches the whole terminal.:command in the namespace view opens a "Go To Path" prompt. Absolute input replaces the current path; relative input is joined onto current andpath.Clean'd (so..,../.., etc. work).Test plan
go build ./...andgo test ./...passmake deploy-bothlobis-eos-dev: longsys.vtrace/sys.aclvalues wrap inside the popup instead of stretching it:opens the prompt; absolute path navigates;..walks up;esccancels