Open
Conversation
added 2 commits
November 1, 2018 10:44
icot
reviewed
Dec 3, 2018
| console.log(this.wrongLines); | ||
| //this.displayedContent = validation; | ||
| //console.log(this.displayedContent); | ||
| if(validation == true){ |
icot
reviewed
Dec 3, 2018
| async validateFile(){ | ||
| if(this.displayedContent!=null){ | ||
| var newContent = this.displayedContent; | ||
| var validation = await this.fileDownloaderService.getValidation(newContent); |
Member
There was a problem hiding this comment.
- validation (to be renamed validated_contents) need to be a unified type in both success an error cases
- As we want to use the contents to display underlined the lines with incorrect changes, you can defined it as an Array[(String, Boolean)], where the string is the line to be displayed and the boolean has the information of whether or not the line is inocrrect to be used in the ngFor and ngIf clauses for the HTML template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.