Skip to content
This repository was archived by the owner on May 7, 2024. It is now read-only.

Soarian FHIR R4 Encounter Resource Documentation#745

Open
SachinPai04 wants to merge 4 commits into
mainfrom
Soarian_Fhir_R4_Encounter_Write
Open

Soarian FHIR R4 Encounter Resource Documentation#745
SachinPai04 wants to merge 4 commits into
mainfrom
Soarian_Fhir_R4_Encounter_Write

Conversation

@SachinPai04
Copy link
Copy Markdown

@SachinPai04 SachinPai04 commented Oct 1, 2021 •
edited
Loading

Description
Soarian FHIR R4 Encounter Resource Documentation

PR Checklist

  • Screenshot(s) of changes attached before changes merged.
    image
    image
    image
    image
    image
    image
    image
    image
    image

  • Screenshot(s) of changes attached after changes merged and published.

HRNWriter
HRNWriter reviewed Oct 1, 2021
View reviewed changes
Comment thread content/soarian/r4/base/management/encounter.md Outdated

## Overview

The Encounter resource provides admissions or visits during which health care services were provided to a patient. An encounter has a class to distinguish between different health care settings such as inpatient, outpatient, emergency and so on.
Copy link
Copy Markdown

@HRNWriter HRNWriter Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the second sentence, please add a comma after "emergency".

Copy link
Copy Markdown
Author

@SachinPai04 SachinPai04 Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes updated.

@ashu-bdvt ashu-bdvt requested a review from sonikrish October 5, 2021 09:52
@sonikrish
Copy link
Copy Markdown
Contributor

sonikrish commented Oct 5, 2021

ReasonCode, ParticipantType is not getting rendered Properly and is not aligned.
Screenshot 2021-10-05 at 4 46 21 PM

Correct notes section Indentation. Header and authorization not getting displayed
Screenshot 2021-10-05 at 4 46 51 PM

Replace the screenshot after correcting changed
Screenshot 2021-10-05 at 4 48 06 PM

@sonikrish
Copy link
Copy Markdown
Contributor

sonikrish commented Oct 5, 2021

Remove Authorization_Types from the list as a separate heading. Authorization types needs to be given individually with each sample url calls. Update the example url calls to have authorization type.
Screenshot 2021-10-05 at 4 53 45 PM

@sonikrish
Copy link
Copy Markdown
Contributor

sonikrish commented Oct 5, 2021

Sample PR #677 to refer

sonikrish
sonikrish suggested changes Oct 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sonikrish sonikrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the screenshots after changes

@SachinPai04
Copy link
Copy Markdown
Author

SachinPai04 commented Oct 18, 2021

ReasonCode, ParticipantType is not getting rendered Properly and is not aligned. Screenshot 2021-10-05 at 4 46 21 PM
There is no indentation problem. That is because of different screenshots it looks like it's not aligned.
Correct notes section Indentation. Header and authorization not getting displayed Screenshot 2021-10-05 at 4 46 51 PM

Replace the screenshot after correcting changed Screenshot 2021-10-05 at 4 48 06 PM

@SachinPai04
Copy link
Copy Markdown
Author

SachinPai04 commented Oct 18, 2021

ReasonCode, ParticipantType is not getting rendered Properly and is not aligned. Screenshot 2021-10-05 at 4 46 21 PM
There is no indentation problem. That is because of different screenshots it looks like it's not aligned. For better view, I will update the screenshots.
Correct notes section Indentation. Header and authorization not getting displayed Screenshot 2021-10-05 at 4 46 51 PM
Replace the screenshot after correcting changed Screenshot 2021-10-05 at 4 48 06 PM

@SachinPai04
Copy link
Copy Markdown
Author

SachinPai04 commented Oct 18, 2021

Remove Authorization_Types from the list as a separate heading. Authorization types needs to be given individually with each sample url calls. Update the example url calls to have authorization type. Screenshot 2021-10-05 at 4 53 45 PM

Updated the changes.

Remove Authorization_Types from the list as a separate heading. Authorization types needs to be given individually with each sample url calls. Update the example url calls to have authorization type. Screenshot 2021-10-05 at 4 53 45 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashu-bdvt ashu-bdvt Awaiting requested review from ashu-bdvt

@MadhurRaj MadhurRaj Awaiting requested review from MadhurRaj

@dougpratt dougpratt Awaiting requested review from dougpratt

@DeepakGupta93 DeepakGupta93 Awaiting requested review from DeepakGupta93

@sudhir80 sudhir80 Awaiting requested review from sudhir80

@VamsiMure VamsiMure Awaiting requested review from VamsiMure

@preethakarnan preethakarnan Awaiting requested review from preethakarnan

3 more reviewers

@HRNWriter HRNWriter HRNWriter left review comments

@sonikrish sonikrish sonikrish approved these changes

@slvsridhar slvsridhar slvsridhar approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SachinPai04 @sonikrish @slvsridhar @HRNWriter