Skip to content

Accessibility: Adding various improvements from Lighthouse recommendations #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Accessibility: Adding various improvements from Lighthouse recommendations #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8b6ed3
Accessibility: Use correct logo aspect ratios
Biscgit Dec 3, 2024
1db568e
Accessibility: More concrete button descriptions
Biscgit Dec 3, 2024
776b35e
Accessibility: Set image alt
Biscgit Dec 3, 2024
449d2cb
JS: fixed missing jquery in theme/page.html
Biscgit Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions cernopendata/modules/globals/ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@ class GlobalVariables:
"width": "auto",
"no_opendata_docs": True,
},
"totem": {
"name": "TOTEM",
"url": "totem-experiment.web.cern.ch",
"width": "auto",
},
"totem": {"name": "TOTEM", "url": "totem-experiment.web.cern.ch"},
}

def __init__(self, app):
Expand Down
2 changes: 2 additions & 0 deletions cernopendata/modules/theme/assets/semantic-ui/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ import jquery from "jquery/dist/jquery";
// ispy and opera visualizers, since other versions are loaded through script
// tag and take over `$` and `jQuery` namespaces.
global.jquery = jquery;

export default jquery;
4 changes: 2 additions & 2 deletions cernopendata/templates/cernopendata_pages/front/lva.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h3 class="row">Learn</h3>
</div>

<div class="more">
<a href="/search?type=Documentation">more</a>
<a href="/search?type=Documentation">Documentation</a>
</div>
</div>
</div>
Expand Down Expand Up @@ -99,7 +99,7 @@ <h3 class="row">Analyse</h3>
</ul>
</div>
<div class="more">
<a href="/research">more</a>
<a href="/research">Further documents</a>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion cernopendata/templates/cernopendata_pages/front/news.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ <h4>
</div>
<div class="more-container">
<div class="more"><a
href="{{url_for('invenio_search_ui.search', f = 'type:News') }}">more</a></div>
href="{{url_for('invenio_search_ui.search', f = 'type:News') }}">All news</a></div>
</div>
</div>
</div>
2 changes: 1 addition & 1 deletion cernopendata/templates/cernopendata_theme/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<img
src="{{ url_for('static', filename='img/experiments/{}.gif'.format(id)) }}"
alt="{{ exp.name }} experiment"
width="{{ exp.get('width', 55) }}"
width="{{ exp.get('width', auto) }}"
height="{{ exp.get('height', 55) }}"
/>
</a>
Expand Down
2 changes: 1 addition & 1 deletion cernopendata/templates/cernopendata_theme/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{%- block navbar %}
<nav class="navbar-custom">
<a class="navbar-brand" href="{{ url_for('cernopendata_pages.index') }}">
<img src="{{ url_for('static', filename='assets/img/logo_blue.png') }}" width="115" alt="">
<img src="{{ url_for('static', filename='assets/img/logo_blue.png') }}" width="115" alt="Open Data CERN">
</a>

<ul class="link-menu">
Expand Down