Skip to content

Include first prototype of the release procedure.#290

Open
psaiz wants to merge 2 commits intomainfrom
communities
Open

Include first prototype of the release procedure.#290
psaiz wants to merge 2 commits intomainfrom
communities

Conversation

@psaiz
Copy link
Copy Markdown
Contributor

@psaiz psaiz commented Mar 13, 2026

No description provided.

@psaiz psaiz force-pushed the communities branch 10 times, most recently from f49d79b to 5e4bc1f Compare March 16, 2026 14:08
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 55.67010% with 387 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.76%. Comparing base (c5d31df) to head (7b02439).

Files with missing lines Patch % Lines
cernopendata/modules/releases/views.py 28.40% 121 Missing ⚠️
cernopendata/modules/releases/api.py 63.81% 93 Missing ⚠️
...nopendata/modules/releases/validations/cms_2016.py 31.57% 39 Missing ⚠️
...ndata/modules/releases/validations/expand_files.py 22.91% 37 Missing ⚠️
cernopendata/modules/releases/validations/files.py 38.09% 26 Missing ⚠️
cernopendata/modules/releases/validations/recid.py 31.57% 26 Missing ⚠️
cernopendata/modules/releases/utils.py 40.00% 24 Missing ⚠️
...ta/modules/releases/validations/duplicate_files.py 43.75% 9 Missing ⚠️
...ta/modules/releases/validations/expected_fields.py 83.33% 7 Missing ⚠️
cernopendata/config.py 94.87% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   63.47%   61.76%   -1.71%     
==========================================
  Files          71       87      +16     
  Lines        2899     3758     +859     
==========================================
+ Hits         1840     2321     +481     
- Misses       1059     1437     +378     
Files with missing lines Coverage Δ
cernopendata/modules/fixtures/cli.py 60.48% <ø> (+1.90%) ⬆️
cernopendata/modules/globals/ext.py 91.83% <100.00%> (+0.34%) ⬆️
cernopendata/modules/releases/models.py 100.00% <100.00%> (ø)
...nopendata/modules/releases/validations/__init__.py 100.00% <100.00%> (ø)
cernopendata/modules/releases/validations/base.py 100.00% <100.00%> (ø)
cernopendata/modules/releases/validations/cms.py 100.00% <100.00%> (ø)
...pendata/modules/releases/validations/experiment.py 100.00% <100.00%> (ø)
...nopendata/modules/releases/validations/metadata.py 100.00% <100.00%> (ø)
cernopendata/version.py 100.00% <100.00%> (ø)
cernopendata/modules/theme/webpack.py 0.00% <0.00%> (ø)
... and 11 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@psaiz psaiz force-pushed the communities branch 18 times, most recently from d0f48d8 to 576dcc5 Compare March 18, 2026 16:53
@psaiz psaiz requested a review from dianarand March 19, 2026 12:22
Comment thread cernopendata/modules/releases/models.py Outdated
Comment thread cernopendata/templates/cernopendata_pages/release_details.html Outdated
Comment thread cernopendata/templates/cernopendata_pages/release_details.html Outdated
__tablename__ = "releases_metadata"

BULK_IMMUTABLE_FIELDS = ["recid", "title", "DOI"]
status = db.Column(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the statuses are defined in ReleaseStatus, maybe it could be used here as an enum, something like
status = db.Column(db.Enum(ReleaseStatus), nullable=False, index=True)

Comment thread cernopendata/modules/releases/api.py
Comment thread cernopendata/modules/theme/assets/semantic-ui/js/curate/RecordsTable.js Outdated
Comment thread cernopendata/modules/releases/api.py Outdated
Comment thread cernopendata/modules/theme/assets/semantic-ui/js/curate/ReleasesTable.js Outdated
Comment thread cernopendata/modules/fixtures/cli.py
@psaiz psaiz force-pushed the communities branch 9 times, most recently from ca0d321 to 4089fd3 Compare March 27, 2026 15:49
Comment thread cernopendata/config.py
handlers["signup_handler"]["info"] = user_info_with_cern_roles

# OAUTHCLIENT_SETTINGS_TEMPLATE = 'invenio_theme/page_settings.html'
COMMUNITIES_CUSTOM_FIELDS = None
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cernopendata webpack clean
# TODO THIS IS A HACK. If we don't create the directory by hand, we get:
# ERROR in ./js/invenio_communities/community/new.js 207:19-76
# 31 110.8 Module not found: Error: Can't resolve '@templates/custom_fields' in '/opt/invenio/var/instance/assets/js/invenio_communities/community'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The passed prop to the UI is here, can you check that this is indeed empty?

It is used in the frontend here. Does the error happen because it is just being imported? If so, we can probably change the import to a dynamic one inside that if block.

…releases and dealing with records. It includes user login, communities and a bunch of new dependencies.

    Co-authored-by: Diana Rand <54885108+dianarand@users.noreply.github.com>
Comment thread cernopendata/modules/releases/validations/files.py
Comment thread cernopendata/modules/releases/models.py Outdated
Co-authored-by: Diana Rand <54885108+dianarand@users.noreply.github.com>
Co-authored-by: psaiz <psaiz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants