feat: MaxConcurrentReconciles can be configured#723
feat: MaxConcurrentReconciles can be configured#723tlwr wants to merge 1 commit intocert-manager:mainfrom
Conversation
At $work we have several thousand namespaces in our production clusters, and in our development clusters >10k namespaces. Reconciliation can take >20 mins, because creation is not concurrent There are two pieces of rate limiting in place 1) the kubernetes API client rate limiter 2) the number of goroutines created by the controller runtime to do reconciliation work This change adjusts (2) so that we can increase the number of goroutines, so we can get configmaps created faster when a full reconciliation is occurring and a new namespace gets created (where the new namespace has to wait behind a full reconcile) (there is also the option of improving the istio-csr use of priority queues, but I (or a colleague) will put that in another pull request) Signed-off-by: toby lorne <toby@toby.codes>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @tlwr. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/honk |
At $work we have several thousand namespaces in our production clusters, and in our development clusters >10k namespaces. Reconciliation can take >20 mins, because creation is not concurrent
There are two pieces of rate limiting in place (in istio-csr already)
reconciliation work
This change adjusts (2) so that we can increase the number of goroutines, so we can get configmaps created faster when a full reconciliation is occurring and a new namespace gets created (where the new namespace has to wait behind a full reconcile)
(There is also the option of improving the istio-csr use of priority queues, ie to prioritise creation, but I (or a colleague) will put that in another pull request)