ctl run: fix overwriting logging level - #2603
Merged
Merged
Conversation
sebix
added
bug
sebix
force-pushed
the
fix-2563
branch
2 times, most recently
from
April 17, 2025 13:42
09e9116 to
80820d2
Compare
Member
Author
|
Rebased to fix the tests |
kamil-certat
approved these changes
Jul 17, 2025
kamil-certat
left a comment
kamil-certat
left a comment
Contributor
There was a problem hiding this comment.
I'd actually prefer when we add an overriding option to the bot class, but it looks reasonable as well.
Fix overwriting the runtime logging level by command line parameter implemented by proper mocking fixes certtools#2563
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix overwriting the runtime logging level by command line parameter implemented by proper mocking