enh: collector_mail_attach allow_empty - #2647
Merged
Merged
Conversation
Member
|
I was thinking about the default value of the new parameter and about the behaviour itself. I think I agree with you, that normally an empty attachment is an error. An error in parsing, the bot configuration or by the sender and needs admin attention. In the parsers, we also don't silently accept a misformatted report. |
sebix
requested changes
Sep 18, 2025
sebix
added
feature
Member
Author
I would have not known either but this was the default behaviour. Thanks, I'll change! |
Member
Author
|
If merging, can you squash by the button so that I don't have to rebase here? (I still may.) |
sebix
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a tag. I keep receiving empty attachments from a partner. Since this is a valid behaviour and there is no reason for a bot to stop, I've added the parameter.