Skip to content

fix: remove type field from registration changeset #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matheusm18 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove type field from registration changeset #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36d576a
fix: remove type field from registration changeset
matheusm18 Dec 23, 2025
e96b26d
fix: update test registration changeset requirements and format code
matheusm18 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/safira/accounts/user.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,11 @@ defmodule Safira.Accounts.User do
"""
def registration_changeset(user, attrs, opts \\ []) do
user
|> cast(attrs, @required_fields ++ @optional_fields)
|> validate_required(@required_fields |> Enum.reject(&(&1 in [:email, :password, :handle])))
|> cast(attrs, (@required_fields ++ @optional_fields) -- [:type])
|> validate_required(
@required_fields
|> Enum.reject(&(&1 in [:email, :password, :handle, :type]))
)
|> validate_email(opts)
|> validate_handle()
|> validate_password(opts)
Expand Down
2 changes: 1 addition & 1 deletion test/safira/accounts_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ defmodule Safira.AccountsTest do
describe "change_user_registration/2" do
test "returns a changeset" do
assert %Ecto.Changeset{} = changeset = Accounts.change_user_registration(%User{})
assert changeset.required == [:password, :handle, :email, :name, :type]
assert changeset.required == [:password, :handle, :email, :name]
end

test "allows fields to be set" do
Expand Down
Loading