Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Angular frontend build stack (including builders/config) and migrates templates to Angular’s new control-flow syntax, while also hardening backend QR-code generation and adjusting Docker/compose artifacts to match new build outputs.
Changes:
- Upgrade frontend dependencies to Angular 21 and switch Angular CLI builders to
@angular/build. - Migrate multiple Angular templates from
*ngIf/*ngForto@if/@forand add explicitstandalone: falsemetadata. - Improve backend QR code fetching robustness and update container build/copy paths and healthchecks.
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/tsconfig.json | Adjust TS compiler options (interop + bundler module resolution) for updated Angular build tooling. |
| frontend/src/main.ts | Modify app bootstrap to include zone change detection provider. |
| frontend/src/app/pages/user-guide/user-guide.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/pages/retrieve-data/retrieve-data.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/pages/retrieve-data/retrieve-data.component.html | Migrate conditional rendering to @if. |
| frontend/src/app/pages/export-settings/export-settings.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/pages/export-settings/export-settings.component.html | Migrate complex form/stepper template to @if control flow. |
| frontend/src/app/pages/download-pending/download-pending.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/pages/download-pending/download-pending.component.html | Migrate *ngIf/*ngFor to @if/@for. |
| frontend/src/app/pages/download-data/download-data.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/pages/download-data/download-data.component.html | Migrate *ngFor to @for. |
| frontend/src/app/modules/download-module/components/download/download.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/modules/download-module/components/download/download.component.html | Migrate *ngIf to @if. |
| frontend/src/app/components/upload-area/upload-area.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/components/map-background/map-background.component.ts | Add explicit standalone: false and minor provider formatting. |
| frontend/src/app/components/map-background/map-background.component.html | Migrate conditional layout to @if/@else. |
| frontend/src/app/components/footer/app-footer.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/components/elevation-profile/elevation-profile.component.ts | Add explicit standalone: false component metadata. |
| frontend/src/app/components/elevation-profile/elevation-profile.component.html | Migrate *ngIf to @if. |
| frontend/src/app/app.component.ts | Add explicit standalone: false component metadata. |
| frontend/package.json | Upgrade Angular packages to v21, adopt @angular/build, and update scripts. |
| frontend/local-dev.Dockerfile | Update Node base image for local dev container. |
| frontend/karma.conf.js | Adjust Karma plugin list as part of Angular build tooling migration. |
| frontend/Dockerfile | Update Node base image and copy path for new Angular build output layout. |
| frontend/angular.json | Switch builders to @angular/build and update output configuration. |
| docker-compose.yml | Adjust frontend healthcheck host/timeout. |
| docker-compose.ci-testing.yml | Align CI healthcheck with local-dev (wget/interval/timeout). |
| backend/automatic_walk_time_tables/utils/qr.py | Add error handling/logging and response validation for QR backend calls. |
| backend/automatic_walk_time_tables/map_downloader/create_map.py | Retry QR generation and omit qr_code attribute when unavailable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
frontend/src/app/pages/retrieve-data/retrieve-data.component.ts
Outdated
Show resolved
Hide resolved
| <div class="elevation-map" *ngIf="plot_options != {}"> | ||
| <h3>Höhenprofil:</h3> | ||
| <p>Mit einem Klick ins Höhenprofil kannst du zusätzliche Wegpunkte einfügen. Diese werden falls | ||
| @if (plot_options != {}) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular Upgrade
This PR bumps angular from 19 to 21.
Fixes
TODO